Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating 'coverage' to address CI failures #1285

Closed
eddyg opened this issue Oct 26, 2022 · 3 comments
Closed

Consider updating 'coverage' to address CI failures #1285

eddyg opened this issue Oct 26, 2022 · 3 comments
Assignees
Labels
enhancement M-T: A feature request for new functionality tests M-T: Testing work only Version: 3x

Comments

@eddyg
Copy link
Contributor

eddyg commented Oct 26, 2022

While looking at the test failures for #1283, I came across this issue in pytest coveragepy which seems like it could be applicable.

A fix was committed in pytest 6.4; might be worth bumping the dependency to see if it improves the reliability of the CI builds.

@seratch seratch self-assigned this Oct 27, 2022
@seratch seratch added enhancement M-T: A feature request for new functionality tests M-T: Testing work only Version: 3x and removed untriaged labels Oct 27, 2022
@seratch seratch changed the title Consider updating 'pytest' to address CI failures Consider updating 'coverage' to address CI failures Oct 27, 2022
@seratch
Copy link
Member

seratch commented Oct 27, 2022

Hi @eddyg, perhaps you meant coverage v6.4+, right? pytest v6 does not exist. The CI builds in this repo can sometimes be unstable due to the following reasons:

  • Unstable behaviors of GitHub Actions containers
  • The load tests for SocketModeClient tend to fail

I am unsure if we should upgrade coverage package for it but we are always happy to upgrade the packages for tests at any time.

@eddyg
Copy link
Contributor Author

eddyg commented Oct 27, 2022

Yes, I did indeed mean coverage. 🤦

The reason that issue sounded like it could be applicable is that when I would review the CI failures, I would often see them "cancelled" at the point where the last thing in the logs was running pytest --cov.

See, for example, these failures: onetwothree

But perhaps "correlation is not causation" in this case. It seems like you're aware of the CI being "flakey".

Please feel free to close this issue!

@seratch
Copy link
Member

seratch commented Oct 28, 2022

@eddyg Thanks for your reply! I've improved the load test for SocketModeClient yesterday. The tests still sometimes fail but I believe that the frequency was much improved. We will continue improving the stability of tests. Let me close this issue now.

@seratch seratch closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality tests M-T: Testing work only Version: 3x
Projects
None yet
Development

No branches or pull requests

2 participants