Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1178 text type hint in LinkButtonElement does not accept PlainTextObject/dict #1183

Merged
merged 1 commit into from Feb 18, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 18, 2022

Summary

This pull request resolves #1178

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Feb 18, 2022
@seratch seratch added this to the 3.16.0 milestone Feb 18, 2022
@seratch seratch self-assigned this Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1183 (5339973) into main (1778647) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   86.68%   86.69%           
=======================================
  Files         110      110           
  Lines       10829    10829           
=======================================
+ Hits         9387     9388    +1     
+ Misses       1442     1441    -1     
Impacted Files Coverage Δ
slack_sdk/models/blocks/block_elements.py 92.87% <ø> (ø)
slack_sdk/socket_mode/builtin/internals.py 72.80% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1778647...5339973. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented Feb 18, 2022

This is a minor one. Let me merge this on my own.

@seratch seratch merged commit 7892a9b into slackapi:main Feb 18, 2022
@seratch seratch deleted the issue-1178 branch February 18, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text type hint in LinkButtonElement does not accept PlainTextObject/dict
1 participant