Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1181 Add exception handling for socket mode - socket.timeout: the read operation timed out #1182

Merged
merged 1 commit into from Feb 19, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 18, 2022

Summary

This pull request resolves #1181

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x socket-mode labels Feb 18, 2022
@seratch seratch added this to the 3.16.0 milestone Feb 18, 2022
@seratch seratch self-assigned this Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1182 (79c1ae5) into main (1778647) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   86.68%   86.66%   -0.03%     
==========================================
  Files         110      110              
  Lines       10829    10834       +5     
==========================================
+ Hits         9387     9389       +2     
- Misses       1442     1445       +3     
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/connection.py 68.23% <83.33%> (+0.23%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 70.61% <0.00%> (-1.76%) ⬇️
slack_sdk/socket_mode/builtin/client.py 91.77% <0.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1778647...79c1ae5. Read the comment docs.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly adding this change!

Comment on lines +177 to +180
if self.trace_enabled:
self.logger.exception(error_message)
else:
self.logger.error(error_message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@seratch seratch merged commit 814da3c into slackapi:main Feb 19, 2022
@seratch seratch deleted the issue-1181 branch February 19, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality socket-mode Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exception handling for socket mode - socket.timeout: the read operation timed out
2 participants