Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ssl_context from the web_client to the websocket #1177

Merged

Conversation

charlch
Copy link
Contributor

@charlch charlch commented Feb 16, 2022

Summary

This PR should fix this bug: #1175

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2022

CLA assistant check
All committers have signed the CLA.

@seratch seratch added this to the 3.15.0 milestone Feb 16, 2022
@seratch seratch self-assigned this Feb 16, 2022
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x labels Feb 16, 2022
@seratch seratch self-requested a review February 16, 2022 22:15
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1177 (51ed8c3) into main (508caa2) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   86.62%   86.63%   +0.01%     
==========================================
  Files         110      110              
  Lines       10789    10793       +4     
==========================================
+ Hits         9346     9351       +5     
+ Misses       1443     1442       -1     
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/client.py 90.50% <ø> (ø)
slack_sdk/socket_mode/builtin/internals.py 72.36% <60.00%> (+1.70%) ⬆️
slack_sdk/socket_mode/builtin/connection.py 68.00% <100.00%> (+0.12%) ⬆️
slack_sdk/socket_mode/websocket_client/__init__.py 84.17% <0.00%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508caa2...51ed8c3. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, looks great to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants