Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin.users.unsupportedVersions.export API support #1174

Merged
merged 2 commits into from Feb 10, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 9, 2022

Summary

This pull request adds admin.users.unsupportedVersions.export API method to the Web API client.

The endpoint always returns ok: true or ok: false + error only. After that, the org admin user who performed the API will receive a DM from Slackbot.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Feb 9, 2022
@seratch seratch added this to the 3.15.0 milestone Feb 9, 2022
@seratch seratch self-assigned this Feb 9, 2022
def admin_users_unsupportedVersions_export(
self,
*,
date_end_of_support: Optional[Union[str, int]] = None,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value should be an integer but, as with other methods in this SDK, both int and str should be accepted here.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1174 (fcb78eb) into main (b5961a4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
+ Coverage   86.62%   86.63%   +0.01%     
==========================================
  Files         110      110              
  Lines       10780    10789       +9     
==========================================
+ Hits         9338     9347       +9     
  Misses       1442     1442              
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 84.95% <100.00%> (+0.04%) ⬆️
slack_sdk/web/client.py 86.36% <100.00%> (+0.04%) ⬆️
slack_sdk/web/legacy_client.py 86.07% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5961a4...fcb78eb. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented Feb 10, 2022

@srajiang Thanks for your review!

@seratch seratch merged commit 508caa2 into slackapi:main Feb 10, 2022
@seratch seratch deleted the admin.users.unsupportedVersions.export branch February 10, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants