Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where some of the files.remote API parameters do not work since v3.10 #1173

Merged
merged 1 commit into from Feb 8, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 8, 2022

Summary

This pull request resolves a bug on files.remote.* API support that affects v3.10, 3.11, 3.12, 3.13, 3.14 users. When we added all the optional parameter support in v3.10, the changes caused a regression bug on those API methods: #1099

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Feb 8, 2022
@seratch seratch added this to the 3.14.1 milestone Feb 8, 2022
@seratch seratch self-assigned this Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1173 (1bece4f) into main (5bb8cce) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files         110      110           
  Lines       10780    10780           
=======================================
  Hits         9338     9338           
  Misses       1442     1442           
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 84.91% <100.00%> (ø)
slack_sdk/web/client.py 86.32% <100.00%> (ø)
slack_sdk/web/legacy_client.py 86.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb8cce...1bece4f. Read the comment docs.

@seratch seratch merged commit f2d2a10 into slackapi:main Feb 8, 2022
@seratch seratch deleted the remote-files-bug branch February 8, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant