Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1170 Add TimePickerElement to BlockElement.parse #1171

Merged
merged 1 commit into from Feb 7, 2022
Merged

Fix #1170 Add TimePickerElement to BlockElement.parse #1171

merged 1 commit into from Feb 7, 2022

Conversation

iress-willygo
Copy link
Contributor

@iress-willygo iress-willygo commented Feb 7, 2022

Summary

Fix #1170, TimePickerElement is missing in BlockElement.parse

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1171 (83d8ef2) into main (779cff5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   86.62%   86.60%   -0.02%     
==========================================
  Files         110      110              
  Lines       10778    10780       +2     
==========================================
  Hits         9336     9336              
- Misses       1442     1444       +2     
Impacted Files Coverage Δ
slack_sdk/models/blocks/block_elements.py 92.39% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779cff5...83d8ef2. Read the comment docs.

@seratch seratch self-assigned this Feb 7, 2022
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client labels Feb 7, 2022
@seratch seratch added this to the 3.14.0 milestone Feb 7, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will add the missing test pattern after merging this.

@seratch seratch merged commit facfc35 into slackapi:main Feb 7, 2022
@iress-willygo iress-willygo deleted the add_timepicker_to_parse branch February 7, 2022 04:06
seratch added a commit that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimePickerElement dictionary is not being parsed
3 participants