Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token rotation feature support #1059

Closed
2 of 9 tasks
seratch opened this issue Jul 12, 2021 · 0 comments · Fixed by #1060
Closed
2 of 9 tasks

Add token rotation feature support #1059

seratch opened this issue Jul 12, 2021 · 0 comments · Fixed by #1060
Labels
enhancement M-T: A feature request for new functionality oauth Version: 3x web-client
Milestone

Comments

@seratch
Copy link
Member

seratch commented Jul 12, 2021

To support a new feature that enables apps to rotate OAuth tokens using a refresh token, we can enhance the OAuth flow by:

  • Add grant_type and refresh_token to oauth_v2_access API method arguments
  • Update the built-in installation store to save refresh_token, expires_in
  • Add oauth.v2.exchange API endpoint support
  • Add the following properties in AuthorizeResult
    • bot refresh token
    • bot token expires at
    • user refresh token
    • user token expires at
  • Update bolt-python's authorize middleware Add token rotation feature support bolt-python#400

To learn more details about the implementation, refer to the Node SDK issue and code:

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x oauth labels Jul 12, 2021
@seratch seratch added this to the 3.8.0 milestone Jul 12, 2021
seratch added a commit to seratch/python-slack-sdk that referenced this issue Jul 14, 2021
seratch added a commit that referenced this issue Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality oauth Version: 3x web-client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant