WebClient's paginated response iterator does not work for admin.conversations.search API #1049
Closed
1 of 11 tasks
Labels
bug
M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
good first issue
semver:minor
Version: 3x
web-client
Milestone
Usually,
next_cursor
in an API response exists underresponse_metadata
property. However, only admin.conversations.search API method's response has it at the top level: https://github.com/slackapi/java-slack-sdk/blob/main/slack-api-client/src/main/java/com/slack/api/methods/response/admin/conversations/AdminConversationsSearchResponse.java#L19Due to this inconsistency, this part in this Python SDK does not work for the API. https://github.com/slackapi/python-slack-sdk/blob/v3.7.0/slack_sdk/web/slack_response.py#L141-L145 We can improve the internals of the class to support the API too.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
The text was updated successfully, but these errors were encountered: