Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1038 by adding admin.auth.policy.* API support #1039

Merged
merged 2 commits into from Jun 15, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 15, 2021

Summary

This pull requests fixes #1038 by adding admin.auth.policy.* API support. Refer to the issue for details.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality semver:minor web-client Version: 3x labels Jun 15, 2021
@seratch seratch added this to the 3.7.0 milestone Jun 15, 2021
@seratch seratch self-assigned this Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1039 (8678d09) into main (3fcdbe1) will decrease coverage by 0.06%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   84.38%   84.31%   -0.07%     
==========================================
  Files          95       95              
  Lines        8869     8938      +69     
==========================================
+ Hits         7484     7536      +52     
- Misses       1385     1402      +17     
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 93.93% <78.26%> (-0.49%) ⬇️
slack_sdk/web/client.py 95.38% <78.26%> (-0.54%) ⬇️
slack_sdk/web/legacy_client.py 95.25% <78.26%> (-0.54%) ⬇️
slack_sdk/socket_mode/builtin/client.py 79.19% <0.00%> (-0.68%) ⬇️
slack_sdk/socket_mode/builtin/connection.py 35.71% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcdbe1...8678d09. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented Jun 15, 2021

Thanks for the review!

@seratch seratch merged commit e2a6843 into slackapi:main Jun 15, 2021
@seratch seratch deleted the issue-1038-admin-auth-policy branch June 15, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin.auth.policy.* API support
2 participants