Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntervalRunner: don't wait for interval_seconds on shutdown #1035

Merged
merged 1 commit into from Jun 14, 2021
Merged

IntervalRunner: don't wait for interval_seconds on shutdown #1035

merged 1 commit into from Jun 14, 2021

Conversation

KostyaEsmukov
Copy link
Contributor

Summary

IntervalRunner.shutdown method currently has to wait the full interval_seconds period due to using a time.sleep call. This change speeds up the shutdown by replacing it with a threading.Event.wait call.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes. [Some e2e tests don't pass with a ConnectionResetError: [Errno 54] Connection reset by peer error]

@gitwave gitwave bot added the untriaged label Jun 14, 2021
@KostyaEsmukov
Copy link
Contributor Author

BTW, the python setup.py validate command fails in a clean venv when running tests with the following error: E ModuleNotFoundError: No module named 'aiohttp'.

@seratch seratch added enhancement M-T: A feature request for new functionality socket-mode Version: 3x and removed untriaged labels Jun 14, 2021
@seratch seratch added this to the 3.7.0 milestone Jun 14, 2021
@seratch seratch self-requested a review June 14, 2021 20:51
@seratch
Copy link
Member

seratch commented Jun 14, 2021

@KostyaEsmukov

BTW, the python setup.py validate command fails in a clean venv when running tests with the following error: E ModuleNotFoundError: No module named 'aiohttp'.

Thanks for pointing this out. It needs to be updated. I will do it later.

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1035 (e421260) into main (fc90f6f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   84.34%   84.34%   -0.01%     
==========================================
  Files          95       95              
  Lines        8878     8877       -1     
==========================================
- Hits         7488     7487       -1     
  Misses       1390     1390              
Impacted Files Coverage Δ
slack_sdk/socket_mode/interval_runner.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc90f6f...e421260. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the solid improvement - LGTM 👍

@seratch seratch merged commit 32d8ae9 into slackapi:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality socket-mode Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants