Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing warning messages #1030 #1032

Merged
merged 2 commits into from Jun 10, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 10, 2021

Summary

This pull request removes the confusing warning log messages in the constructors of Block Element base classes. As I mentioned at #1030 (comment), we generally don't recommend directly using the base classes such as InteractiveElement and InputInteractiveElement as these classes does not provide optimal ways to construct data for each block element.

That said, displaying !!! InputInteractiveElement's constructor args (initial_value) were ignored.If they should be supported by this library, report this issue to the project :bow: https://github.com/slackapi/python-slack-sdk/issues for valid properties does not help us improve anything. Therefore, we will remove the warnings from the two classes.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1032 (d38fb86) into main (0a7918a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   84.32%   84.32%   -0.01%     
==========================================
  Files          95       95              
  Lines        8880     8878       -2     
==========================================
- Hits         7488     7486       -2     
  Misses       1392     1392              
Impacted Files Coverage Δ
slack_sdk/models/blocks/block_elements.py 92.30% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7918a...d38fb86. Read the comment docs.

@seratch seratch merged commit 0ed7672 into slackapi:main Jun 10, 2021
@seratch seratch deleted the issue-1030-remove-warnings branch June 10, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant