Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket_client based SocketModeClient may fail in on_close callback #1025

Closed
seratch opened this issue May 28, 2021 · 0 comments · Fixed by #1026
Closed

websocket_client based SocketModeClient may fail in on_close callback #1025

seratch opened this issue May 28, 2021 · 0 comments · Fixed by #1026
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x
Milestone

Comments

@seratch
Copy link
Member

seratch commented May 28, 2021

@daverstam Thanks for sharing the results. This is greatly helpful! I appreciate it. As you guessed, regularly reconnecting to a new endpoint is a normal behavior. However,

ERROR:websocket:error from callback <function SocketModeClient.connect..on_close at 0x7f40e5ce2dc0>: on_close() takes 1 positional argument but 3 were given

this error should be fixed. I will create a new issue for this and will look into this.

If you don't see anything that is strange behavior and should be more investigated I think this case can be closed. If you want to further investigate I will gladly assist in any way I can.

Thank you very much for saying this! Although we are keen to reduce unnecessary disconnections, I intentionally designed the built-in client to promptly detect lost connections as early as possible for apps' stability. As long as the reconnection does not fail, we can safely say that this is not a critical issue. As you suggested, I would like to close this issue for now. Thanks again for your help on this 👍

Originally posted by @seratch in #1024 (comment)

@gitwave gitwave bot added the untriaged label May 28, 2021
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x and removed untriaged labels May 28, 2021
@seratch seratch added this to the 3.6.0 milestone May 28, 2021
@seratch seratch changed the title websocket_client based SocketModeClient may fail in on_error callback websocket_client based SocketModeClient may fail in on_close callback May 28, 2021
seratch added a commit to seratch/python-slack-sdk that referenced this issue May 28, 2021
seratch added a commit to seratch/python-slack-sdk that referenced this issue May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x
Projects
None yet
1 participant