Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin.apps.uninstall support #1011

Merged
merged 2 commits into from May 7, 2021
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 30, 2021

Summary

This pull request adds admin.apps.uninstall API support. The endpoint is available only for Enterprise Grid organizations.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality semver:minor web-client Version: 3x labels Apr 30, 2021
@seratch seratch added this to the 3.6.0 milestone Apr 30, 2021
@seratch seratch self-assigned this Apr 30, 2021
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1011 (1fa232b) into main (7d28505) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files          95       95           
  Lines        8749     8776   +27     
=======================================
+ Hits         7575     7599   +24     
- Misses       1174     1177    +3     
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 94.42% <88.88%> (-0.07%) ⬇️
slack_sdk/web/client.py 95.91% <88.88%> (-0.09%) ⬇️
slack_sdk/web/legacy_client.py 95.78% <88.88%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d28505...1fa232b. Read the comment docs.

@seratch seratch merged commit 833e3c5 into slackapi:main May 7, 2021
@seratch seratch deleted the admin.apps.uninstall branch May 7, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants