Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "timepicker" element #1259

Closed
4 of 9 tasks
80rian opened this issue Jun 7, 2021 · 3 comments
Closed
4 of 9 tasks

Support "timepicker" element #1259

80rian opened this issue Jun 7, 2021 · 3 comments
Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` release semver:minor
Milestone
types@2.1

Comments

@80rian
Copy link

80rian commented Jun 7, 2021 •
edited

Description

Describe your issue here.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

I have built a slack bot in Javascript and I just started porting it to Typescript(&nestjs).
I didn't have any problem working with timepicker element in js but it seems like timepicker is not yet implemented to types.
I am not sure if it's just adding another interface to a union type or not.
If it's just that simple, I can definitely work on it and PR. If not, please consider implementing timepicker type.
I know timepicker is still in beta, but something that works with js should work with ts, right?
Let me know!
@gitwave gitwave bot added the untriaged label Jun 7, 2021
@seratch seratch added area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` release semver:minor and removed untriaged labels Jun 7, 2021
@seratch seratch added this to the types@2.1 milestone Jun 7, 2021
@seratch
Copy link
Member

seratch commented Jun 7, 2021

Hi @80rian, thanks for taking the time to report this!

We recently added timepicker to the package: #1226 but haven't yet released a new version. As we don't have anything further for the next release, we can release a new version shortly.

@80rian
Copy link
Author

80rian commented Jun 7, 2021

@seratch Thanks for a quick reply!
Sorry for missing that pr and it looks exactly like what I did!
I can close this issue.

@80rian 80rian closed this as completed Jun 7, 2021
@seratch seratch mentioned this issue Jun 7, 2021
Merged
2 tasks
@seratch
Copy link
Member

seratch commented Jun 8, 2021

FYI, the interface is now available in @slack/types@2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` release semver:minor
Projects
None yet
Milestone
types@2.1
Development

No branches or pull requests
2 participants
@seratch @80rian