Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9+ Modularity Supports #198

Open
denismakogon opened this issue Aug 8, 2019 · 6 comments
Open

Java 9+ Modularity Supports #198

denismakogon opened this issue Aug 8, 2019 · 6 comments
Labels
enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model
Milestone

Comments

@denismakogon
Copy link

trying out a simple slack API within a module, but seeing this problem

Error: Modules jslack.api.client and jslack.api.model export package com.github.seratch.jslack.common.json to module okio

it doesn't seem like jslack was ever adjusted to work with Project Jigsaw (java 9 modules).

@seratch
Copy link
Member

seratch commented Aug 8, 2019

Thank you for your feedback. Honestly, I'm not familiar with making libraries compatible with Java modules yet but I'd love to make jslack modules-ready. Could you help me?

@seratch
Copy link
Member

seratch commented Sep 12, 2019

I revisited this issue a little bit but let me hold working on this. I would like to continue supporting Java 8 for a while.

@jhg023
Copy link

jhg023 commented Sep 24, 2019

@seratch I'd be happy to submit a pull request to fix this, while still maintaining Java 8 compatibility.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model labels Jan 27, 2020
@seratch seratch changed the title Unable to module modules with jslack Java 9+ Modularity Supports Feb 17, 2020
@seratch seratch added this to the 2.0.0 milestone Oct 1, 2020
@tvladyka-photobox
Copy link

tvladyka-photobox commented Nov 2, 2021

That is really needed thing, we unable to use in the project slack-api-client together with slack-api-model in project due to lack of modularity support
[ERROR] module <our-module> reads package com.slack.api.meta from both slack.api.client and slack.api.model

@sebastien-lamps
Copy link

sebastien-lamps commented Nov 11, 2021

Tricky thing to make slack API compatible with Java Module system:

  • Same "public" packages are present in 2 jars: "com.slack.api.meta" and "com.slack.api.util.json"
  • slack-api-model uses internal class from Google GSON dependency (as workaround for a bug)

@bsalture
Copy link

bsalture commented Jan 3, 2024

Dear Slack Devs, what is the state of this issue? It still produces error in module-info.java when using your client lib. When do you plan to fix this? Thx Benjamin

grafik
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model
Projects
None yet
Development

No branches or pull requests

6 participants