Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the logic to extract the requestUserId for context objects #1147

Open
1 of 6 tasks
seratch opened this issue Apr 28, 2023 · 0 comments
Open
1 of 6 tasks

Improve the logic to extract the requestUserId for context objects #1147

seratch opened this issue Apr 28, 2023 · 0 comments
Assignees
Labels
enhancement M-T: A feature request for new functionality project:bolt
Milestone

Comments

@seratch
Copy link
Member

seratch commented Apr 28, 2023

While testing this new feauture, I found that the logic to set context.requestUserId can be improved for Events API patterns. I will make changes for it in a different pull request.

As I mentioned at #1144, bolt-java's user ID extration for context objects can be improved like bolt-python does.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. 🙇

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt labels Apr 28, 2023
@seratch seratch added this to the 1.30.0 milestone Apr 28, 2023
@seratch seratch self-assigned this Apr 28, 2023
@seratch seratch modified the milestones: 1.30.0, 1.31.0 Jul 5, 2023
@seratch seratch modified the milestones: 1.32.0, 1.33.0 Sep 12, 2023
@seratch seratch modified the milestones: 1.33.0, 1.34.0, 1.x Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt
Projects
None yet
Development

No branches or pull requests

1 participant