Support remote files API #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledmonster
force-pushed
the
feature/remote-file
branch
from
fe729c4
to
8ccbda4
Compare
kanata2
reviewed
Dec 9, 2020
ledmonster
force-pushed
the
feature/remote-file
branch
from
8ccbda4
to
ecbe29c
Compare
ledmonster
force-pushed
the
feature/remote-file
branch
from
ecbe29c
to
46dc7e1
Compare
ledmonster
force-pushed
the
feature/remote-file
branch
from
56feeb9
to
3eb3ab3
Compare
|
@kanata2 Added tests for remotefiles module. |
|
@kanata2 |
|
Sorry for slow response. I'll confirm in the next few days... |
kanata2
reviewed
Mar 16, 2021
| } | ||
|
|
||
| // AddRemoteFile adds a remote file | ||
| func (api *Client) AddRemoteFile(params RemoteFileParameters) (remotefile *RemoteFile, err error) { |
There was a problem hiding this comment.
Suggested change
| func (api *Client) AddRemoteFile(params RemoteFileParameters) (remotefile *RemoteFile, err error) { | |
| func (api *Client) AddRemoteFile(params RemoteFileParameters) (*RemoteFile, error) { |
| } | ||
|
|
||
| // ListRemoteFiles retrieves all remote files according to the parameters given. Uses cursor based pagination. | ||
| func (api *Client) ListRemoteFiles(params ListRemoteFilesParameters) ([]RemoteFile, *ListRemoteFilesParameters, error) { |
There was a problem hiding this comment.
How about using string instead of ListRemoteFilesParameters in returned value?
I think ListRemoteFilesParameters should be used only as an argument to ListRemoteFiles.
|
Please add documentation link to each GoDoc comment 🙏 |
kanata2
added
the
feedback given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports remote files APIs (#856)
I implemented remotefiles module referencing files module.