Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support slack events about file #1115

Merged
merged 2 commits into from Nov 4, 2022

Conversation

andyhaskell
Copy link
Contributor

This PR adds support for deserializing file_change, file_deleted, file_shared, and file_unshared events from the Slack Events API

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andyhaskell
Copy link
Contributor Author

@kanata2 No problem! Btw it looks like in the 1.17 tests, TestGetRTMInfo is failing. I haven't used this CI system before, so I was wondering, is there a way to restart that build? At least the wording there makes it sound like a transient issue

@kanata2
Copy link
Member

kanata2 commented Nov 4, 2022

Actually, this test is so fraky...
I understood test failure is not related to this changes, so I'll merge.

@kanata2 kanata2 merged commit f1c8f0a into slack-go:master Nov 4, 2022
@kanata2 kanata2 changed the title Deserialize file events Support slack events about file Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants