Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UploadFileContext not calling api.AuthTestContext #1109

Merged
merged 1 commit into from Sep 11, 2022
Merged

fix: UploadFileContext not calling api.AuthTestContext #1109

merged 1 commit into from Sep 11, 2022

Conversation

kevin-faliam
Copy link

@kevin-faliam kevin-faliam commented Sep 3, 2022 •
edited

UploadFileContext was calling api.AuthTest instead of api.AuthTestContext

@kanata2
Copy link
Member

kanata2 commented Sep 9, 2022

@kevin-faliam Please add description for your changes.

@kanata2 kanata2 added api cleanup feedback given When a review has been conducted and awaiting the response from the comitter(s) labels Sep 9, 2022
kanata2
kanata2 approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Sep 11, 2022
@kanata2 kanata2 merged commit ba4dcc3 into slack-go:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
api cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevin-faliam @kanata2 @ktseng