Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetUserGroups call in README #1065

Merged
merged 1 commit into from May 18, 2022
Merged

Conversation

photown
Copy link
Contributor

@photown photown commented May 17, 2022

GetUserGroups expects a GetUserGroupsOption parameter, not a boolean one.

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

GetUserGroups expects a GetUserGroupsOption parameter, not a boolean one.
@kanata2
Copy link
Member

kanata2 commented May 18, 2022

Thanks :)

@kanata2 kanata2 merged commit 3cd1edc into slack-go:master May 18, 2022
@kanata2 kanata2 added documentation example about example codes labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation example about example codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants