webhooks: discarding body after http requests in order to allow reusi… #1061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you do more than 1 call using the provided http client, the connection won't be reused and a new potentially expensive TCP connection will be established.
In order for the connection to be reused by the Transport you need to read the response body in full and close the response.
this is from the go source code comment [https://pkg.go.dev/net/http]:
Note:
ioutil.Discard is used but if the lib supports golang >= 1.16 then it should become io.Discard.
Additionally, ioutil.Discard is used in other places that's why I picked that.
Best