New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bookmarks.<add|edit|remove|list>
support
#1044
Conversation
Co-authored-by: Winston Durand <me@winstondurand.com>
bookmarks.*
supportbookmarks.<add|edit|remove|list>
support
@winston-stripe will review soon |
@winston-stripe |
@zchee sg, and i've removed the dependency on |
@winston-stripe Passes test. Thanks! |
Hmm, BTW go1.14 or older is too old. I want to protect the @kanata2 Could you add me to the owner role? |
lmk if there's anything else you need from me here :) |
@zchee granted you a repo's admin role. 😄 |
@winston-stripe will review again. sorry for the late |
hi @zchee, have you had a chance to review this again yet? |
@R167 sorry for the late. |
hi, just bumping this PR again 😃 (appreciate your time!) |
@kanata2 thanks for the checks! I fixed those spelling mistakes for when you have a chance to look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
one more followup: anything more to do here, or is it just "wait for the v0.11.0 milestone thing" and PRs will be merged then? |
merged |
Summary
Add support for the
bookmarks.<add|edit|remove|list>
endpoints https://api.slack.com/apis/bookmarks-apiMotivation
Implements bookmarks per request in #1036
PR preparation
Run
make pr-prep
from the root of the repository to run formatting, linting and tests.API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
This PR does include API changes since it exposes new endpoints for accessing
bookmarks.add
https://api.slack.com/methods/bookmarks.addbookmarks.edit
https://api.slack.com/methods/bookmarks.editbookmarks.remove
https://api.slack.com/methods/bookmarks.removebookmarks.list
https://api.slack.com/methods/bookmarks.listAll implemented methods include tests