Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null value in JSONTime #1106

Merged
merged 2 commits into from Sep 11, 2022
Merged

Handle null value in JSONTime #1106

merged 2 commits into from Sep 11, 2022

Conversation

rusq
Copy link
Contributor

@rusq rusq commented Aug 31, 2022

Handle the NULL value, when API returns "timestamp": null

It returns JSONTime(0) in this case.

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

Handle the NULL value, when API returns "timestamp": null
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kanata2 kanata2 added the bugfix [PR] bugfix label Sep 11, 2022
@kanata2 kanata2 changed the title Handle possible null in JSONTime Unmarshal. Handle null value in JSONTime Sep 11, 2022
@kanata2 kanata2 merged commit d197559 into slack-go:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix [PR] bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants