Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GetUsersOptionTeamID so that a team ID can be passed in for use #1077

Merged
merged 11 commits into from Jun 14, 2022
Merged

Added GetUsersOptionTeamID so that a team ID can be passed in for use #1077

merged 11 commits into from Jun 14, 2022

Conversation

antonylucisano
Copy link
Contributor

  • GetUsers and GetUsersContext now takes Options
  • Added team ID as an additional option as this is required for Organization level API calls used in GRID

@antonylucisano
Copy link
Contributor Author

/assign @kanata2

kanata2
kanata2 reviewed Jun 12, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

users.go Outdated Show resolved Hide resolved
@kanata2 kanata2 added feedback given When a review has been conducted and awaiting the response from the comitter(s) api cleanup enhancement and removed api cleanup labels Jun 12, 2022
@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jun 14, 2022
@kanata2 kanata2 merged commit 819628f into slack-go:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonylucisano @kanata2