Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Permalink to Msg struct #1069

Merged
merged 3 commits into from Jun 14, 2022
Merged

Add Permalink to Msg struct #1069

merged 3 commits into from Jun 14, 2022

Conversation

jreinstra
Copy link
Contributor

At least in the Slack list-stars method if not others, a permalink is included with each item returned. This permalink is not available via slack-go because it is not a field on the struct used to parse that response, so this change adds that missing field.

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

At least in the Slack list-stars method if not others, a permalink is included with each item returned. This permalink is not available via slack-go because it is not a field on the struct used to parse that response, so this change adds that missing field.
messages.go Outdated Show resolved Hide resolved
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I commented, please confirm.

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jun 6, 2022
Co-authored-by: Naoki Kanatani <k12naoki@gmail.com>
@jreinstra
Copy link
Contributor Author

Thanks for your contribution! I commented, please confirm.

Oh whoops, accepted fix, thanks!

@kanata2 kanata2 self-requested a review June 7, 2022 04:19
@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jun 12, 2022
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one minor style-related fix, so please confirm 🙏

messages.go Outdated Show resolved Hide resolved
Co-authored-by: Naoki Kanatani <k12naoki@gmail.com>
@jreinstra
Copy link
Contributor Author

I found one minor style-related fix, so please confirm 🙏

whoops, accepted, thanks!

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@kanata2 kanata2 merged commit 1119d2a into slack-go:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants