Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refresh_token and token_type to OAuthV2Response fields #1030

Merged
merged 1 commit into from Feb 12, 2022
Merged

Add refresh_token and token_type to OAuthV2Response fields #1030

merged 1 commit into from Feb 12, 2022

Conversation

hidenami-i
Copy link
Contributor

@hidenami-i hidenami-i commented Feb 10, 2022 •
edited

Added missing parameters (refresh_token and token_type) to the AuthedUser block of OAuthV2Response.

https://api.slack.com/methods/oauth.v2.access

@zchee zchee mentioned this pull request Feb 10, 2022
Closed
@zchee
Copy link
Contributor

zchee commented Feb 10, 2022

ref:
https://github.com/slackapi/node-slack-sdk/blob/88f9abe72089bad3b10f31c823a71fa8cc8a019d/packages/oauth/src/index.ts#L645-L709

cc: @kanata2

kanata2
kanata2 approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kanata2 kanata2 merged commit 9cad061 into slack-go:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hidenami-i @zchee @kanata2