Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Gem v5.1.0 does not work with Ruby 2.5.x #352

Open
lvangool opened this issue May 25, 2021 · 5 comments
Open

Latest Gem v5.1.0 does not work with Ruby 2.5.x #352

lvangool opened this issue May 25, 2021 · 5 comments

Comments

@lvangool
Copy link

This is because internally you do:

YAML.safe_load(ERB.new(File.read(path)).result, permitted_classes: [], permitted_symbols: [], aliases: true)

Which causes the error:

ArgumentError: unknown keywords: permitted_classes, permitted_symbols, aliases

Because those arguments aren't available in psych in Ruby 2.5.x

@lvangool lvangool changed the title Latest Gem v5.1.0 does work with Ruby 2.5.x Latest Gem v5.1.0 does not work with Ruby 2.5.x May 25, 2021
@wagenet
Copy link
Contributor

wagenet commented May 25, 2021

@lvangool Ruby 2.5 is EOL so we no longer support it. That said, we should have changed our gemspec accordingly. I'll keep this open until we've fixed that.

@zvkemp
Copy link
Contributor

zvkemp commented May 28, 2021

Version 5.1.1 includes an updated gemspec. As this doesn't really solve the issue of 5.1.0 continuing to resolve for ruby 2.5, I'm going to leave this issue open for now.

@fbarriosCL
Copy link

Hi any solution, I have the same problem?

could not load config file; msg=unknown keywords: permitted_classes, permitted_symbols, aliases (Skylight::ConfigError)

@wagenet
Copy link
Contributor

wagenet commented Mar 28, 2022

@fbarriosCL you'll just need to specify an older version of the gem less than 5.1.

@wagenet
Copy link
Contributor

wagenet commented Mar 28, 2022

I've yanked 5.1.0. 5.1.1 is otherwise identical but has the correct dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants