Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sequel integration probe stops working if you load the :error_sql extension #153

Open
pabloh opened this issue Jul 28, 2020 · 1 comment

Comments

@pabloh
Copy link

pabloh commented Jul 28, 2020

The sequel integration doesn't load if you are using the :error_sql extension in your sequel database object.

https://sequel.jeremyevans.net/rdoc-plugins/files/lib/sequel/extensions/error_sql_rb.html

https://github.com/jeremyevans/sequel/blob/master/lib/sequel/extensions/error_sql.rb#L60

There's an issue regarding how this plugin interact with the sequel probe.

One possible solution would be convert or offload the sequel probe functionality into a sequel extension in order to allow manually activating the extension; given that the conflict with the :error_sql extension and Skylight code happens only when they are loaded on a specific order.

@pabloh pabloh changed the title Error when using Sequel integration probe The sequel integration probe stops working if you load the :error_sql extension Jul 29, 2020
@wagenet
Copy link
Contributor

wagenet commented Sep 1, 2020

@pabloh my apologies for the lack of reply earlier. Is this something you'd be interested in working on? I can help from our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants