Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template name for Tilt probe? #105

Open
mkdynamic opened this issue Oct 12, 2017 · 2 comments
Open

Use template name for Tilt probe? #105

mkdynamic opened this issue Oct 12, 2017 · 2 comments

Comments

@mkdynamic
Copy link

How about using the Tilt::Template#name as a fallback in the Tilt probe.

Proposed change would be something like this:

-title: options[:sky_virtual_path] || "Unknown template name"
+title: options[:sky_virtual_path] || name || "Unknown template name"
@wagenet
Copy link
Contributor

wagenet commented Oct 12, 2017

I think this makes sense. I'll have to do some investigation to make sure. Thanks for bringing it up!

@mkdynamic
Copy link
Author

Thanks @wagenet -- if it helps, here's what we ended up running:
v1.4.2...delighted:v1.4.2.x1

Obviously would need some work to generalize that, but the aim was trying to get the "title" value that shows in Skylight to match for virtual_path style generated by the action view instrumentation.

An easier, general solution might be to just use the basename instead since the extension is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants