Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Java wrapper build by default. #368

Merged
merged 1 commit into from Aug 3, 2020
Merged

Conversation

tedski
Copy link

@tedski tedski commented Aug 2, 2020

  • Java wrapper build isn't necessary for all Python builds.
  • Java wrapper build can now be enabled with ENABLE_JAVA environment
    variable.

@skvark
Copy link
Member

skvark commented Aug 2, 2020

There can be only 4 sdist builds because there are exactly 4 different distributions in PyPI, no need to modify the build matrix. The environment variable is not really needed, Java could be just hardcoded off in all builds since this repository is building the Python wrapper, not the Java one.

@tedski
Copy link
Author

tedski commented Aug 2, 2020

I wanted to leave the environment variable in case there were current users that needed the Java wrapper from the build. Let me know if you still want me to remove it.

setup.py Show resolved Hide resolved
@tedski tedski force-pushed the master branch 2 times, most recently from 8351b92 to 54c1d56 Compare August 3, 2020 15:37
- Java wrapper build isn't necessary for all Python builds.
- Java wrapper build can now be enabled with ``ENABLE_JAVA`` environment
  variable.
@skvark
Copy link
Member

skvark commented Aug 3, 2020

Thanks!

@skvark skvark merged commit 83acfc9 into opencv:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants