Don't build unused Qt features; use all cores #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, that's a quite big change in the image size. I don't think people are using OpenCV to build actual user interfaces so the icon issue is not a big deal. There are indeed some merge conflicts which must be resolved before merge. |
# Conflicts: # docker/Dockerfile_i686 # docker/Dockerfile_x86_64
skvark
pushed a commit
that referenced
this pull request
Sep 5, 2019
* Don't build unused Qt features; use all cores * cmake does bootstrapping, too; comment unclear steps * Use Docker comment syntax * tab to space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drastically reduces Qt compilation time and reduces the resulting image size by about 440M.
The resulting libs included into the wheel are reduced by about 600k.
I've checked that none of the excluded features are used:
imshow()UI. But it's also present in the vanilla wheel.-no-nisand-no-cupsbut ultimately decided against them: I'm not sure that the UI has no printing capabilities. (NIS support is used solely to discover network printers.)Merge conflicts with #229 are all but guaranteed.