Minor fixes in build logic #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failures in Linux are due to network problems. |
|
Fails for 3.7 in MacOS are a CMake problem. Something changed in 3.7.3 library layout and CMake cannot find the library. The last release was built against 3.7.0. |
…support This reverts commit d4a5198. cmake 3.14 can't find py3 installation when "python" points to Python 3 while cmake 3.9 can
|
It turns out, CMake 3.9 preinstalled in |
|
Thanks. This looks ok, I'll merge if you don't have any additional changes coming in. |
Not yet. Not yet. :-) |
|
👍 Please create new PR for new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various noncritical tidbits that have been bugging me. See commit messages for details.