Fix OSX builds and migrate to Xcode 8.3 #182
Conversation
* Add explanation to more obscure cmake args
* fix built bottle & metadata cleanup when bottle is missing * -e mode for before_cache step * faster finish when already the latest version
* disable auto `brew cleanup` * support formulae with disabled bottles * install alongside to avoid "runtime dependents" update https://discourse.brew.sh/t/can-i-install-a-new-version-without-having-to-upgrade-runtime-dependents/4443
* Reduce the number of command lines executed in most used functions * List existing versions only when installing
* Add a dedicated stage to each OSX build to download/build brew packages * Remove bottle building logic and the corresponding trace output from the project build stage
|
Thank you. I will renegerate the Docker images before merging this, I completely forgot that earlier... |
|
Contrib builds fail due to opencv/opencv_contrib#920 . I added a fix there -- you can temporarily switch the submodule to my branch if you don't want to wait for upstream. |
|
About that contrib build issue: is Tesseract now a dependency in contrib builds or did the builds fail even without Tesseract? If we disable Tesseract via cmake flags, would the build pass with older opencv_contrib version 4.0.0? I rebuilt the Docker images yesterday so ccache should work in future builds correctly. |
|
Tesseract has been a dependency of contrib module This error only surfaced now because in the I don't see how to explicitly disable tesseract in https://github.com/opencv/opencv_contrib/blob/master/modules/text/CMakeLists.txt , so you'll have to uninstall it, I guess, if you want to build without it. I don't really see a problem with buiding against the fixed submodule commit because it's just after the release, with no functional differences. |
I stay corrected, there are, but only a few: opencv/opencv_contrib@4.0.1...fdb575d |
|
Thanks for the information. It's fine to keep it as a dependency since explicitly uninstalling it just adds more work. And thanks again for this PR. I have been lately too occupied with other stuff and it would have taken me a lot of time to find the root cause to this issue. |
It's fine, I'll just add a note to the release that the contrib version does not match exact tag due to the bug. |
On a closer inspection, it's a dependency of the |
For the record, this means that it can be excluded when generating the custom formula, the same way as GPL libraries. |
Subj. Major changes to react to are:
opensslwould now lead to upgrading more than 60 packages linked against the old version.ffmpeg's dependencies (indirectly) and its update conflicts with multibuild-installed python. Moreover, Homebrew upgrades the installed Py2 to Py3 as the "default" python.brewformula has more GPLed components.Other changes are:
(I also see that you never regenerated x86 Docker images as promised. So Linux x86 builds still run without ccache.)