Fix sealed subclass picking #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only consider sealed subclasses that have no more than expected number of constructor args
then prefer the class having higher total constructor arguments number
|
awesome 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #331 fix, this changes the sealed subclass picking logic,
If there are subclasses having more mandatory constructor arguments than the number of configuration properties provided, then such subclasses will be ignored at all.
If there are 2 classes having the same number of arguments in constructor: one with optional and one with mandatory, the one with mandatory will be preferred.
If there are 2 classes having the same number of mandatory arguments in the constructor, the one having higher total number of arguments will be preferred.