Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sentry as a required dependency #81

Open
danielwestendorf opened this issue Aug 24, 2022 · 2 comments
Open

Remove sentry as a required dependency #81

danielwestendorf opened this issue Aug 24, 2022 · 2 comments

Comments

@danielwestendorf
Copy link
Contributor

We use a different bug tracking tool than sentry. Adding rspecq to the gem file and running some tests results in failures. I have traced this back to conflicts between the two bug tracking tools.

Since it doesn't make sense for us to include sentry in our dependency graph, does it make sense for sentry to be an optional dependency?

@fragoulis
Copy link
Contributor

Sentry should be abstracted away to an interface that may or may not send results to some api. That is true. There are a number of ideas on how this can be done, for example as events (active support notifications, kafka) and/or plugins (like sentry, datadog etc).

@agis
Copy link
Collaborator

agis commented Sep 7, 2022

At the very least, the Sentry integration should only kick in if the gem is loaded (e.g. defined?(Sentry)). I believe this should solve your issue @danielwestendorf, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants