Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nokogiri to 1.11.0 when ready #93

Closed
skoji opened this issue Jan 10, 2020 · 10 comments
Closed

Update Nokogiri to 1.11.0 when ready #93

skoji opened this issue Jan 10, 2020 · 10 comments
Assignees

Comments

@skoji
Copy link
Owner

skoji commented Jan 10, 2020

@skoji skoji self-assigned this Jan 10, 2020
@chloerei
Copy link

Is it possible to replace nokogiri with rexml? Install nokogiri in ubuntu need almost 200mb for compilation tools, it's too big for a command line tool that I want to distribute via docker...

@skoji
Copy link
Owner Author

skoji commented Jan 17, 2020

@chloerei I think it's possible but not so easy. I'm thinking of introducing XML abstraction layer to switch XML library, like epub-parser.

@chloerei
Copy link

@skoji If Nokogiri is not superior to REXML under the requirements of this gem(Maybe performance?), I think REXML is enough. Abstraction layer required extra work and maybe not important for user.

Also I found I can install ruby-nokogiri package from ubuntu repo, that need 34.8 MB space, less then compile at install time. I feel better now.

@skoji
Copy link
Owner Author

skoji commented Jan 18, 2020

I think performance is important for some use cases. (e.g. asciidoctor-epub3)

@chloerei
Copy link

chloerei commented Jan 19, 2020

I also depend on Nokogiri to parse HTML, so don't need to worry about it.


Revoke this comment.

@flavorjones
Copy link

Nokogiri release candidate v1.11.0.rc1 has been released with precompiled native libraries for Windows and Ruby 2.7. Please give it a whirl and let me know if you have any problems.

slonopotamus added a commit to slonopotamus/gepub that referenced this issue Feb 3, 2020
@slonopotamus
Copy link
Contributor

I can't believe there's still no stable Nokogiri release for Ruby 2.7 on Windows.

@flavorjones
Copy link

@flavorjones
Copy link

Nokogiri v1.10.10 has been released with precompiled support for Ruby 2.7 on Windows.

@slonopotamus
Copy link
Contributor

I've created #120 that enables CI on Windows + Ruby 2.7 (and it passes)

@skoji skoji closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants