Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile after adding isemail #205

Open
benjiwheeler opened this issue Aug 11, 2019 · 1 comment
Open

Cannot compile after adding isemail #205

benjiwheeler opened this issue Aug 11, 2019 · 1 comment

Comments

@benjiwheeler
Copy link

benjiwheeler commented Aug 11, 2019

I did this:

  1. added isemail to my package.json, pegged to a 3.x.x version (i don't remember which)
  2. npm install'ed
  3. in my react code, required isemail and used isemail.validate()
  4. tried to compile my code

But I got an error complaining:

Module not found: Error: Can't resolve 'dns' in '<PATH_TO_MY_REPO>/node_modules/isemail/lib'

Is this related to #24 ?

One note: I did see that another dependency of mine was using isemail v1.2.0; not sure how npm resolves that kind of situation.

@WesTyler
Copy link
Contributor

Can you run npm ls isemail? I suspect the error is coming from the sub-dependency, because we ripped the dns module out of isemail entirely in v3.

(Also thanks for the new issue :) much easier to help this way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants