Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowUnicode option, default to true #156

Closed
WesTyler opened this issue Jun 26, 2017 · 3 comments
Closed

Add allowUnicode option, default to true #156

WesTyler opened this issue Jun 26, 2017 · 3 comments
Assignees
Labels

Comments

@WesTyler
Copy link
Contributor

We should include an option to "disable" international character recognition, per discussion in hapijs/joi#931 .

Default behavior should be to allow international, since that is the more recent RFC.

@WesTyler
Copy link
Contributor Author

I arbitrarily called it allowUnicode just to have enough info for an issue. Defer to @skeggse on implementation details.

@skeggse skeggse self-assigned this Jun 27, 2017
@skeggse
Copy link
Owner

skeggse commented Jun 27, 2017

I'm working on a rewrite that moves this module closer to being an email address parser with validation as added functionality. As opposed to using a massive state machine, it'll implement the parser as a recursive descent parser. It'll make the code way easier to work with, but in the meantime, I'll try to write a patch that adds this flag.

@skeggse
Copy link
Owner

skeggse commented Jan 18, 2018

c640d2e, landed in v3.1.0.

@skeggse skeggse closed this as completed Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants