Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-cli don't pull changes in skale-node after unsuccessful node update #739

Open
OleksanderSalamatov opened this issue Sep 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@OleksanderSalamatov
Copy link

After unsuccessful update node-cli pulls skale-node only in .skale/.tmp/config dir, but .skale/config is still old, which cause update to fail if it is incorrect

Steps to reproduce the behavior:

  1. Upgrade with incorrect docker-compose.yml
  2. Correct docker-compose.yml in skale-node
  3. Run skale node update
  4. Error still present
~# skale node update init-env --yes
...
2023-09-22 12:22:40,647 - INFO - /root/.skale/.tmp/config exists, removing...
2023-09-22 12:22:40,649 - INFO - Creating /root/.skale/.tmp/config directory...
2023-09-22 12:22:40,649 - INFO - Cloning https://github.com/skalenetwork/skale-node.git → /root/.skale/.tmp/config
2023-09-22 12:22:41,240 - INFO - Fetching config changes
2023-09-22 12:22:41,466 - INFO - Checkouting /root/.skale/.tmp/config to regression-2.2
...
Invalid interpolation format for "command" option in service "node-exporter": "--collector.filesystem.mount-points-exclude=^/(mnt|dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/.+)($|/)"

~# cat .skale/.tmp/config/docker-compose.yml | grep "collector.filesystem"
      - '--collector.filesystem.mount-points-exclude=^/(mnt|dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/.+)($$|/)'
~# cat .skale/config/docker-compose.yml | grep "collector.filesystem"
      - '--collector.filesystem.mount-points-exclude=^/(mnt|dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/.+)($|/)'
@OleksanderSalamatov OleksanderSalamatov added the bug Something isn't working label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant