Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl bug #291

Open
anyouuu opened this issue Apr 4, 2018 · 5 comments
Open

curl bug #291

anyouuu opened this issue Apr 4, 2018 · 5 comments

Comments

@anyouuu
Copy link

anyouuu commented Apr 4, 2018

comand "$ curl http://localhost:5000/participate?experiment=button_color&alternatives=red&alternatives=blue&client_id=12345678-1234-5678-1234-567812345678
"

server exception :

^C----------------------------------------
Error on request:
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/werkzeug/serving.py", line 177, in run_wsgi
execute(self.server.app)
File "/usr/local/lib/python2.7/dist-packages/werkzeug/serving.py", line 165, in execute
application_iter = app(environ, start_response)
File "/usr/local/lib/python2.7/dist-packages/sixpack/server.py", line 71, in call
return self.app(environ, add_cors_headers)
File "/usr/local/lib/python2.7/dist-packages/sixpack/server.py", line 92, in call
return self.wsgi_app(environ, start_response)
File "/usr/local/lib/python2.7/dist-packages/sixpack/server.py", line 101, in wsgi_app
return response(environ, start_response)
File "/usr/local/lib/python2.7/dist-packages/werkzeug/wrappers.py", line 1169, in call
start_response(status, headers)
File "/usr/local/lib/python2.7/dist-packages/sixpack/server.py", line 56, in add_cors_headers
get_origin(status, headers))
File "/usr/local/lib/python2.7/dist-packages/sixpack/server.py", line 51, in get_origin
return origin if self.origin_regexp.match(origin) else "null"
AttributeError: 'NoneType' object has no attribute 'match'

@JuneKelly
Copy link

I just ran into this while setting up sixpack for local testing and evaluation. Is sixpack even maintained any more? there's an open pull request (#280) that fixes this issue, but it's been open since last year with no word from the maintainers.

As it stands, the setup documentation leads straight to this crash, with the current version of sixpack.

@zackkitzmiller
Copy link
Contributor

zackkitzmiller commented Oct 14, 2018

Merged 280. I’ll release tomorrow.

@JuneKelly
Copy link

Thanks @zackkitzmiller !

@Singwai
Copy link

Singwai commented Oct 16, 2018

Since this is merged. can we close this?

@JuneKelly
Copy link

The code is fixed, but the sixpack package on pypi is still at 2.7.0, released last year, so the bug is still present for anyone setting up sixpack now.

A new 2.7.x release should do it 👍 , and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants