Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 Bad Request from Conversion endpoint when the winner has been chosen #284

Open
momasz opened this issue Oct 16, 2017 · 0 comments
Open

Comments

@momasz
Copy link

momasz commented Oct 16, 2017

I am getting 400 Bad Request from /convert endpoint after the winner of my experiment has been chosen.

I am aware that an experiment should be deleted after the winner is selected https://github.com/seatgeek/sixpack#production-notes BUT would not it be better if /convert endpoint responded with some more friendly information like can not convert an experiment that ended?

or at least, to provide some additional parameter inside /participate endpoint which can tell us that the winner for this experiment has been chosen, ex:

{
    "status": "ok",
    "alternative": {
        "name": "redirect"
    },
    "experiment": {
        "name": "registration"
    },
    "client_id": "100",
    "winnerSelected": true
}

any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant