terminal_check_solaris.go doesn't have a build tag and is breaking the build on AppEngine

[Hexcles]

logrus/terminal_check_solaris.go

Line 1 in 9b3cdde

package logrus

I think this file should have a build tag like:

// +build solaris

similar to

logrus/terminal_check_unix.go

Line 1 in 9b3cdde

// +build linux aix

I believe this is the reason logrus currently fails to build on AppEngine standard projects (where we can't use golang.org/x/sys/unix).

[dgsb]

I don't fix it will fix the build break because the _<platform_name>.go is an implicit +<platform_name> build constraint.
You can try that fix anyway and we will see what happens.

[dgsb]

Just curious how do you build for appengine ? Cross-compile from a linux host ?

[Hexcles]

@dgsb sorry, looks like my proposed fix wouldn't solve the problem, but bisecting led me to the real culprit that is also related to terminal: #943 , which moved terminal package into the root logrus package.

My AppEngine project imports the github.com/sirupsen/logrus package but not terminal. Before #943 my project deploys fine but once I check out past #943 I'm seeing this error:

2019/04/05 08:35:03 go-app-builder: Failed parsing input: parser: bad import "unsafe" in golang.org/x/sys/unix/affinity_linux.go

I'm not exactly familiar with the underlying implementation of AppEngine Go. The SDK actually bundles in a special go toolchain to build the binary. Any unsafe stuff (for example in golang.org/x/sys/unix, which is imported by various terminal_check*.go) can't be used on AppEngine. Previously things worked since the terminal package was separate and I never import it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.