Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.4.1 doesn't cross-compile for Solaris #945

Closed
prymitive opened this issue Apr 2, 2019 · 4 comments
Closed

v1.4.1 doesn't cross-compile for Solaris #945

prymitive opened this issue Apr 2, 2019 · 4 comments

Comments

@prymitive
Copy link

It looks like 1.4.1 breaks cross compilation for solaris.
See https://travis-ci.com/prymitive/karma/jobs/189733896#L761-L762

2019/04/02 17:43:23 fatal: There was an error! goos='solaris' goarch='amd64' err='exit status 2' stdout='' stderr='# github.com/sirupsen/logrus
../../../../pkg/mod/github.com/sirupsen/logrus@v1.4.1/terminal_check_notappengine.go:13:10: undefined: isTerminal
@dgsb dgsb mentioned this issue Apr 3, 2019
Merged
@dgsb
Copy link
Collaborator

dgsb commented Apr 3, 2019

fixed by #946
New label incoming today

@prymitive
Copy link
Author

New label incoming today as in "new release"?

@PhouvanhKCSV
Copy link

Waiting for this

@dgsb
Copy link
Collaborator

dgsb commented May 18, 2019

v1.4.2 has been released today

@dgsb dgsb closed this as completed May 18, 2019
@kmoe kmoe mentioned this issue Jun 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prymitive @dgsb @PhouvanhKCSV