Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextFormatter uses isTerminal before it's initialized #1298

Closed
deadok22 opened this issue Nov 24, 2021 · 4 comments · May be fixed by #1299
Closed

TextFormatter uses isTerminal before it's initialized #1298

deadok22 opened this issue Nov 24, 2021 · 4 comments · May be fixed by #1299
Labels
stale

Comments

@deadok22
Copy link

The isColored call in this snippet uses the isTerminal flag before it is initialized on the last line of this snippet. That results in the sort order of the fields in the first message formatted via TextFormatter not having its fields sorted.
deadok22 added a commit to deadok22/logrus that referenced this issue Nov 24, 2021
@deadok22
Initialize the isTerminal field before using it
033d041 
Fixes sirupsen#1298
@deadok22 deadok22 mentioned this issue Nov 24, 2021
Open
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 25, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Jan 8, 2022
@deadok22
Copy link
Author

There's an approved MR: #1299

@artem-leonov artem-leonov mentioned this issue Feb 16, 2023
Closed
@deadok22
Copy link
Author

How do I reopen this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize the isTerminal field before using it deadok22/logrus
1 participant
@deadok22