Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faraday rate limit argument issue #97

Closed
vietqhoang opened this issue Jan 18, 2023 · 3 comments
Closed

Faraday rate limit argument issue #97

vietqhoang opened this issue Jan 18, 2023 · 3 comments

Comments

@vietqhoang
Copy link

vietqhoang commented Jan 18, 2023

Relevant dependencies

  • ruby version 3.2.0
  • airrecord version 1.0.10
  • faraday version 1.10.2

Problem

The following error is raised when method chain Airrecord.table.create is called.

ArgumentError: wrong number of arguments (given 2, expected 1)

The error is sourced from [GEM_ROOT]/gems/airrecord-1.0.10/lib/airrecord/faraday_rate_limiter.rb:9:in 'initialize'.

When running the application in Ruby 3.1.2 the issue does not exist.

Reviewing the Ruby 3.2.0 changes it looks like this may be related to ruby2_keywords changes.

@Keqi
Copy link

Keqi commented Jan 19, 2023

Hey, we're experiencing the same issue. Any timeline to fix it? 🙏

@Meekohi
Copy link
Collaborator

Meekohi commented Jan 19, 2023

@Keqi I don't think anyone is actively working on this gem currently -- PRs welcome.

@vietqhoang
Copy link
Author

vietqhoang commented Jan 20, 2023

Rounding back to this.

The recent faraday 1.10.3 update has addressed this issue by implementing the ruby2_keyword shim to address the keyword argument incompatibility in Ruby 3.

See the following:

The error reported in the original post goes away once the faraday dependency has updated to at least 1.10.3. This can be done in your project with bundle update faraday.

Closing this since a solution has been identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants