Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #318.
Reduce the maximum memory requirement of the
JarArchiveComparator
by having it apply filters while classes are being loaded and removing them from theClassPool
when filtered.If a package filter is encountered we switch to a 2 step procedure, first reading all package filters, then reloading all classes. (Quite annoying but I don't see an alternative apart from rejecting the PR).
Diff is a bit larger than desired so tests like
FilterTest
, that relied on filtering to happen after aCtClass
is created, continue to work as-is.