Rework CI to add multi-version build and Maven repository caching #294
Conversation
.github/workflows/ci.yml
Outdated
| on: | ||
| push: | ||
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
What about simply having:
on: [push, pull_request]which would trigger the build for any branch?
Also, not sure you really need the workflow_dispatch as there is no special parameter or execution flow and the previous builds can be always retriggered using the Actions UI.
There was a problem hiding this comment.
I applied my suggestions but am happy to roll them back if you see problems with them.
scordio
force-pushed
the
rework_ci
branch
2 times, most recently
from
9754a03
to
d853d18
Compare
|
@siom79 now that the build was triggered, it seems that japicmp has issues with Java 17+. |
|
Now 17 passes, but further errors with 18+. |
|
Seems to be related to the system-rules library. I have created an issue: stefanbirkner/system-rules#85 |
|
I noticed that there is a dedicated python script to trigger the maven-release-plugin, or at least I assume you do it locally. Would you like to do that via GitHub workflow? I can raise a PR with something similar to https://github.com/assertj/assertj-core/blob/main/.github/workflows/release.yml. |
|
That would be great. I would merge it... |
I noticed the CI configuration was repeated three times, so I refactored it to use the build matrix.
Relevant changes:
actions/setup-javato version 2 and enabled the built-in Maven cache