Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and Set Assertion Logging Limits #2484

Open
sgoossens opened this issue Dec 12, 2022 · 1 comment
Open

Enable and Set Assertion Logging Limits #2484

sgoossens opened this issue Dec 12, 2022 · 1 comment
Labels

Comments

@sgoossens
Copy link
Contributor

when sinon.assert fails for a stubbed method that had potentially a large amount of data on it, it logs the entirety of the stub each time which can cause runoff on the terminal see here making it very hard to debug. It would be nice to be able to toggle on a log threshold limit such that we can control the amount that is logged out when an assertion fails.

fatso83 added a commit to fatso83/sinon that referenced this issue Oct 25, 2023
Co-authored-by: Spencer Goossens <sgoossens18@gmail.com>
Co-authored-by: Carl-Erik Kopseng <carlerik@gmail.com>
fatso83 added a commit to sgoossens/sinon that referenced this issue Oct 25, 2023
Co-authored-by: Spencer Goossens <sgoossens18@gmail.com>
Co-authored-by: Carl-Erik Kopseng <carlerik@gmail.com>
fatso83 added a commit that referenced this issue Oct 27, 2023
* Cleanup unimported setup & include test files

* Remove redundant assign

The 'assert' object is already present on the sandbox

* fix(#2484): add assertion log limit

* Document the existing sandbox and create-sandbox

* Expose opts.assertOptions on createSandbox(opts)

* Verify options are passed down

* Remove needless accessors

* Make test behavior oriented rather than implementation specific.

---------

Co-authored-by: Spencer Goossens <sgoossens18@gmail.com>
Co-authored-by: Carl-Erik Kopseng <carlerik@gmail.com>
Copy link

stale bot commented Dec 27, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant