Fix fake tests #2439
Merged
Fix fake tests #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2439 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 41 41
Lines 1906 1906
=======================================
Hits 1830 1830
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
I just closed fatso83/mini-mocha#23, which basically was about that the test runner should exit with a non-zero status if a test fails. As soon as that was updated, our example tests in Sinon failed 馃ぁ So this PR fixes the failing tests that the bugfix found.
I also flattened the tests for fakes, removing the
describeblock. Since it did not describe any specific issue, I felt it did not really do much in helping the understanding, so I thought it just as well could be removed. I also renamed the test files (for fakes only) to have them run in numerically sorted order.